Discussion:
[ABRT PATCH] xorg_event.conf: use abrt-action-list-dsos to create dso_list
Denys Vlasenko
2013-08-26 13:16:19 UTC
Permalink
We used to use a shell script for this, but its format lists just
a package name:
mesa-dri-drivers-8.0.4-1.fc17.x86_64
instead of the more informative format used by ccpp:
/usr/lib64/libssl3.so nss-3.14.3-2.fc18.x86_64 (Fedora Project) 1370297473

An added benefit is that by using abrt-action-list-dsos, we reuse code and use
the same format of list of DSOs for ccpp and xorg problems.

Signed-off-by: Denys Vlasenko <dvlasenk-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
---
src/plugins/xorg_event.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/plugins/xorg_event.conf b/src/plugins/xorg_event.conf
index 1bd7617..e6d0a3a 100644
--- a/src/plugins/xorg_event.conf
+++ b/src/plugins/xorg_event.conf
@@ -2,9 +2,9 @@ EVENT=post-create analyzer=xorg
# Blacklist known binary-only modules.
# Generate duplicate detection hashes.
abrt-action-analyze-xorg
-
+ #
# Get versions of binaries listed in Xorg backtrace
- cat backtrace | cut -f2 -d" " | xargs rpm -qf | sort -u >> backtrace_binaries_versions
+ abrt-action-list-dsos -m backtrace -o dso_list
#
test -f /var/log/Xorg.0.log && cp /var/log/Xorg.0.log .
test -f /etc/X11/xorg.conf && cp /etc/X11/xorg.conf .
--
1.8.1.4
Richard Marko
2013-08-29 09:52:41 UTC
Permalink
Pushed.
Post by Denys Vlasenko
We used to use a shell script for this, but its format lists just
mesa-dri-drivers-8.0.4-1.fc17.x86_64
/usr/lib64/libssl3.so nss-3.14.3-2.fc18.x86_64 (Fedora Project) 1370297473
An added benefit is that by using abrt-action-list-dsos, we reuse code and use
the same format of list of DSOs for ccpp and xorg problems.
---
src/plugins/xorg_event.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/plugins/xorg_event.conf b/src/plugins/xorg_event.conf
index 1bd7617..e6d0a3a 100644
--- a/src/plugins/xorg_event.conf
+++ b/src/plugins/xorg_event.conf
@@ -2,9 +2,9 @@ EVENT=post-create analyzer=xorg
# Blacklist known binary-only modules.
# Generate duplicate detection hashes.
abrt-action-analyze-xorg
-
+ #
# Get versions of binaries listed in Xorg backtrace
- cat backtrace | cut -f2 -d" " | xargs rpm -qf | sort -u >> backtrace_binaries_versions
+ abrt-action-list-dsos -m backtrace -o dso_list
#
test -f /var/log/Xorg.0.log && cp /var/log/Xorg.0.log .
test -f /etc/X11/xorg.conf && cp /etc/X11/xorg.conf .
--
Richard Marko
Loading...